Thread (4 messages) flat view 4 messages, 3 authors, 2019-05-17

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

From: David Howells <dhowells@redhat.com>
Date: 2019-05-17 07:13:34
Also in: linux-fsdevel, lkml

Christian Brauner [off-list ref] wrote:
If you still prefer to have cloexec flags
for the 4 new syscalls then yes,
if they could at least all have the same name
(FSMOUNT_CLOEXEC?) that would be good.
They don't all have the same value (see OPEN_TREE_CLOEXEC).

Note that I also don't want to blindly #define them to O_CLOEXEC because it's
not necessarily the same value on all arches.  Currently it can be 02000000,
010000000 or 0x400000 for instance, which means that if it's sharing a mask
with other flags, at least three bits have to be reserved for it or we have to
have arch-dependent bit juggling.

One thing I like about your approach of just making them O_CLOEXEC by default
and removing the constants is that it avoids this mess entirely.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help