Re: [PATCH v3 6/7] arm64: Advertise ARM64_HAS_DCPODP cpu feature

From
Dave Martin <Dave.Martin@arm.com>
Date
2019-04-03 09:32:55
Also in
linux-arm-kernel
Reply to
Andrew Murray, 2019-04-03
On Wed, Apr 03, 2019 at 10:23:42AM +0100, Andrew Murray wrote:
On Tue, Apr 02, 2019 at 03:59:58PM +0100, Dave Martin wrote:
quoted
On Mon, Apr 01, 2019 at 11:45:14AM +0100, Andrew Murray wrote:
quoted
Advertise ARM64_HAS_DCPOP when both DC CVAP and DC CVADP are supported.
Do you mean ARM64_HAS_DCPODP?
Yes I did - good catch.
quoted
And do we need this?  This capability flag doesn't currently appear to
be used for anything (which makes me wonder whether it _should_ be wired
up to something in the kernel).

Do we expect the kernel to do something special with this in the future?

OTOH, we get a nice printk when the feature is detected, and the code
size cost is insignificant.  So, if there's a reasonable expectation that
we will use it someday, I don't see a big problem with having it.
Yes it's not currently used, so I'm happy to drop this patch if people prefer
that - however it does complement the existing DCPOP cap which is present.
OK, sounds fine.

Maybe add a note in the commit message that this is here for consistency
with DCPOP, and we anticipate it being used in the future.

Cheers
---Dave
Thread (23 messages) 23 messages, 3 authors, last reply 2019-04-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help