Re: [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output

On Sun, Apr 07, 2019 at 09:02:38PM +0800, Li, Aubrey wrote:

On 2019/4/7 5:41, Alexey Dobriyan wrote:

quoted

On Fri, Apr 05, 2019 at 09:32:35PM +0200, Thomas Gleixner wrote:

quoted

quoted

+/* Add support for architecture specific output in /proc/pid/status */
+extern void arch_proc_pid_status(struct seq_file *m, struct task_struct *task);

     ^^^^^^

Unnecessary extern.

The linkage is default extern, but with this functions and variables
can be treated the same way.

Is it mandatory not to use it explicitly? ./script/checkpatch.pl did
not report this.

"extern" is only necessary for variables. For prototypes, it is more typing
and more characters on the screen.

checkpatch.pl doesn't report it because opening floodgates is not the plan.

Yours,
	Extern Police.