Re: [PATCH 05/18] Add io_uring IO interface

Jeff Moyer [off-list ref] writes:

Hi, Jens,

Jens Axboe [off-list ref] writes:

quoted

+static void io_ring_ctx_free(struct io_ring_ctx *ctx)
+{
+	destroy_workqueue(ctx->sqo_wq);

You need to make sure sqo_wq is non-null before calling
destroy_workqueue.

You also need to check for non-null sqo_files and sqo_mm.

Basically, you're tearing things down twice if setup of the context
fails in some way.

-Jeff

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>