Thread (47 messages) flat view 47 messages, 6 authors, 2019-03-27

Re: [PATCH 05/32] timerfd/timens: Take into account ns clock offsets

From: Cyrill Gorcunov <hidden>
Date: 2019-02-06 08:55:30
Also in: lkml

On Wed, Feb 06, 2019 at 11:52:03AM +0300, Cyrill Gorcunov wrote:
...
quoted
 
-	if ((flags & ~TFD_SETTIME_FLAGS) ||
-		 !itimerspec64_valid(new))
-		return -EINVAL;
Please don't defer this early test of a @flags value. Otherwise
if @flags is invalid you continue fget/put/clock-to-host even
if result will be dropped out then.
Just to clarify -- this could be done on top of the series to
not resend the whole bunch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help