Re: [RESEND PATCH v3 2/2] sysctl: handle overflow for file-max
flat view
From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: 2019-01-08 07:05:53
Also in:
lkml
On Mon, Jan 07, 2019 at 11:27:00PM +0100, Christian Brauner wrote:
quoted hunk ↗ jump to hunk
@@ -2833,6 +2836,10 @@ static int __do_proc_doulongvec_minmax(void *data, struct ctl_table *table, int break; if (neg) continue; + if ((max && val > *max) || (min && val < *min)) { + err = -EINVAL; + break; + } val = convmul * val / convdiv; if ((min && val < *min) || (max && val > *max)) continue;
This is a generic change which affects all users of do_proc_doulongvec_minmax() that have extra1 or extra2 set. In sysctl.c, I do not see another user of proc_doulongvec_minmax() that has extra1 or extra2 set. However, have you verified whether your patch changes the behaviour for other files that make use of proc_doulongvec_minmax() or proc_doulongvec_ms_jiffies_minmax(), and not only of the file-max sysctl? Thanks, Dominik