On Thu, Dec 06, 2018 at 10:30:40AM -0800, Kees Cook wrote:
On Thu, Dec 6, 2018 at 9:41 AM Christian Brauner [off-list ref] wrote:
quoted
I feel changing the name around by a single persons preferences is not
really a nice thing to do community-wise. So I'd like to hear other
people chime in first before I make that change.
I don't think the name is hugely critical (but it's always the hardest
to settle on). My preference order would be:
taskfd_send_signal()
pidfd_send_signal()
procfd_send_signal()
fd_send_signal()
imo, either procfd_send_signal() or taskfd_send_signal()
It seems to me that using flags later to specify sending to pgrp vs thread
is fine: it's specifying how to interpret the 'fd' in 'procfd_send_signal()'.
But, agreed, I think fdkill() should not be used.
--
Kees Cook