Re: [RFC PATCH for 4.21 03/16] mm: Replace BUG_ON() by WARN_ON() in vm_unmap_ram()

On Thu, 1 Nov 2018 13:21:12 +0100 (CET)
Thomas Gleixner [off-list ref] wrote:

Mathieu,

On Thu, 1 Nov 2018, Mathieu Desnoyers wrote:

quoted

It is encouraged to warn and return rather than use BUG_ON() when
the condition can be recovered from in ways that are more graceful than
halting the whole system.  

You're failing to desribe how that graceful recovery works.

I think the graceful recovery is to simply return:

	if (WARN_ON(cond))
		return;

is better than just

	BUG_ON(cond);

As that's what Linus made pretty clear at the Maintainer's Summit.

-- Steve