Re: [RFC PATCH for 4.21 04/16] mm: Introduce vm_map_user_ram, vm_unmap_user_ram

From
Sergey Senozhatsky <hidden>
Date
2018-10-17 15:34:24
Also in
lkml
Reply to
Mathieu Desnoyers, 2018-10-17
On (10/17/18 11:04), Mathieu Desnoyers wrote:
quoted
quoted
quoted
	if (WARN_ON(x))
		return;
Given that this somewhat MM-related, I'd may be say VM_WARN_ON().
I notice that VM_WARN_ON() casts the result of WARN_ON() to (void), so it
cannot be used in a if () statement.

VM_WARN_ON() will only warn if CONFIG_DEBUG_VM is set.

Is it really what we want ?
Oh, indeed... Sorry, I forgot that they cast WANR_ON() return to void.
Let's do what Steven suggested.

	-ss
Thread (40 messages) 40 messages, 6 authors, last reply 2018-10-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help