Thread (40 messages) 40 messages, 5 authors, 2018-11-20

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2018-09-25 22:04:10
Also in: linux-mm, lkml

On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes [off-list ref] wrote:
quoted
quoted
It is also used in 
automated testing to ensure that vmas get disabled for thp appropriately 
and we used "nh" since that is how PR_SET_THP_DISABLE previously enforced 
this, and those tests now break.
This sounds like a bit of an abuse to me. It shows how an internal
implementation detail leaks out to the userspace which is something we
should try to avoid.
Well, it's already how this has worked for years before commit 
1860033237d4 broke it.  Changing the implementation in the kernel is fine 
as long as you don't break userspace who relies on what is exported to it 
and is the only way to determine if MADV_NOHUGEPAGE is preventing it from 
being backed by hugepages.
1860033237d4 was over a year ago so perhaps we don't need to be
too worried about restoring the old interface.  In which case
we have an opportunity to make improvements such as that suggested
by Michal?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help