Thread (37 messages) 37 messages, 9 authors, 2018-10-09

Re: [PATCH 05/11] UAPI: coda: Don't use internal kernel structs in UAPI

From: Jan Harkes <jaharkes@cs.cmu.edu>
Date: 2018-09-05 22:00:11
Also in: linux-fsdevel, linux-kbuild, lkml

On Wed, Sep 05, 2018 at 07:12:37PM +0200, Yann Droneaud wrote:
Le mercredi 05 septembre 2018 à 16:55 +0100, David Howells a écrit :
quoted
The size and layout of internal kernel structures may not be relied
upon outside of the kernel and may even change in a containerised
environment if a container image is frozen and shifted to another
machine.

Excise these from Coda's upc_req struct.
...
This structure should not have been exposed to userspace in the first
place: it's unusable by userspace as it is. It was incorrect to have it
outside of #ifdef __KERNEL__ before commit 607ca46e97a1b ... 
...
So the structure can be moved back to <linux/coda_psdev.h>.
I found a year old patch that clearly fell through the cracks that
fixes this exact thing.

    https://lkml.org/lkml/2017/8/6/186

Jan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help