Re: [RFC PATCH for 4.18 3/5] rseq: uapi: declare rseq_cs field as union, update includes
flat view
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: 2018-07-06 19:36:01
Also in:
lkml
----- On Jul 6, 2018, at 3:31 PM, Linus Torvalds torvalds@linux-foundation.org wrote:
On Fri, Jul 6, 2018 at 12:23 PM Mathieu Desnoyers [off-list ref] wrote:quoted
For -rc, I would favor the following simpler approach. Or I could even just use get_user() instead. Thoughts ?Please just use "get_user()". In fact, we should be thinking seriosly about just removing __get_user() entirely. It's wrong. It optimizes the wrong thing entirely. It _used_ to be that the range check was noticeable, and it really isn't any more. These days the expensive parts are the SMAP costs, and both get_user() and __get_user() have those, except get_user() is safer and doesn't waste I$ on inlining the code to disable and re-enable SMAP.
Will do, thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com