Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-07-12 16:17:59
Also in:
linux-fsdevel, lkml
Possibly related (same subject, not in this thread)
- 2018-07-19 · Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9] · Eric W. Biederman <hidden>
On Thu, Jul 12, 2018 at 9:00 AM Al Viro [off-list ref] wrote:
Wait a sec - that's only a problem if your command contains pointer-chasing et.al.
No.
It's a problem if anybody ever does something like "let's have a
helper splice thread that uses splice to move data automatically from
one buffer to another".
And yes, it's something people have wanted.
Seriously. I'm putting my foot down. NO COMMANDS IN WRITE DATA!
We have made that mistake in the past. Having done stupid things in
the past is not an excuse for doing so again. Quite the reverse.
Making the same mistake and not learning from your mistakes is the
sign of stupidity.
So I repeat: write is for data. If you want an action, you do it with
ioctl, or you do it with a system call.
Linus