Re: [PATCH 1/4] lib/rhashtable: simplify bucket_table_alloc()
From: Randy Dunlap <hidden>
Date: 2018-06-21 21:33:21
Also in:
lkml
On 06/21/2018 02:28 PM, Davidlohr Bueso wrote:
As of ce91f6ee5 (mm: kvmalloc does not fallback to vmalloc for incompatible gfp flag), we can simplify the caller and trust kvzalloc() to just do the right thing.
Hi, JFYI, we are using 12-digit (12-character) commit IDs nowadays...
quoted hunk ↗ jump to hunk
Signed-off-by: Davidlohr Bueso <redacted> --- lib/rhashtable.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 9427b5766134..26c9cd8a985a 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c@@ -175,10 +175,7 @@ static struct bucket_table *bucket_table_alloc(struct rhashtable *ht, int i; size = sizeof(*tbl) + nbuckets * sizeof(tbl->buckets[0]); - if (gfp != GFP_KERNEL) - tbl = kzalloc(size, gfp | __GFP_NOWARN | __GFP_NORETRY); - else - tbl = kvzalloc(size, gfp); + tbl = kvzalloc(size, gfp); size = nbuckets;
-- ~Randy