Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

From
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date
2018-03-28 19:48:48
Also in
netdev
Reply to
Steven Rostedt, 2018-03-28
----- On Mar 28, 2018, at 3:40 PM, rostedt rostedt@goodmis.org wrote:
On Wed, 28 Mar 2018 12:38:48 -0700
Alexei Starovoitov [off-list ref] wrote:
quoted
On 3/28/18 12:34 PM, Steven Rostedt wrote:
quoted
On Wed, 28 Mar 2018 12:05:37 -0700
Alexei Starovoitov [off-list ref] wrote:
 
quoted
+++ b/include/linux/tracepoint-defs.h
@@ -35,4 +35,10 @@ struct tracepoint {
 	struct tracepoint_func __rcu *funcs;
 };

+struct bpf_raw_event_map {
+	struct tracepoint	*tp;
+	void			*bpf_func;
+	u32			num_args;
+} __aligned(32);
+
If you prefer v7, I'm fine with that. For cache issues, I can pull out
the funcs from the tracepoint structure like I posted.
I very much prefer to land this v8 as-is and optimize later.

I still have bpfilter/microkernel patches to finish which were
practically ready two weeks ago and got delayed but this set.
Then by all means, you have my Ack. We can optimize later.

For the whole series... (v7 or v8)

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
I'm fine with either v7 or v8 as well.

Thanks,

Mathieu
Thanks!

-- Steve
-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
Thread (15 messages) 15 messages, 5 authors, last reply 2018-03-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help