Thread (1 message) 1 message, 1 author, 2018-01-17

Re: [PATCH 32/32] aio: implement io_pgetevents

From: Jeff Moyer <hidden>
Date: 2018-01-17 13:51:28
Also in: linux-fsdevel, lkml, netdev

Christoph Hellwig [off-list ref] writes:
On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
quoted
I'd be willing to bet the issue is in your io_syscall6 implementation.
You pass in arg5 where arg6 should be used.  Don't feel bad, it took me
the better part of today to figure that out.  :)

Here's an incremental diff on top of what you've posted.  Feel free to
fold it into your patch (and format however you like).  You can find the
libaio changes in my 'aio-poll' branch:
  https://pagure.io/libaio/commits/aio-poll

These changes were run through the libaio test harness, 64 bit and 32
bit, so the compat system call was tested.
Oops, yes.  Although I prefer the copy_from_user version, this is what
I had:
Much cleaner.

Thanks!
Jeff

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help