Thread (44 messages) 44 messages, 14 authors, 2017-12-22

known bad patch in -mm tree was Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

From: Pavel Machek <hidden>
Date: 2017-12-21 14:59:12
Also in: linux-arch, linux-mm, lkml

Hi!
quoted
quoted
quoted
And if Michal doesn't want to touch this patch any more, I'm happy to
do the search/replace/resend. :P
Something with the prefix MAP_FIXED_ seems to me obviously desirable,
both to suggest that the function is similar, and also for easy
grepping of the source code to look for instances of both.
MAP_FIXED_SAFE didn't really bother me as a name, but
MAP_FIXED_NOREPLACE (or MAP_FIXED_NOCLOBBER) seem slightly more
descriptive of what the flag actually does, so a little better.
Great, thanks!

Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series?
This seems to have not happened. Presumably Andrew just missed the mail
in the flood. And will probably miss this one too ... :)
Nice way to mess up kernel development, Michal. Thank you! :-(.

Andrew, everyone and their dog agrees MAP_FIXED_SAFE is stupid name,
but Michal decided to just go ahead, ignoring feedback...

Can you either s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g or drop the patches?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help