Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote:

2017-11-09 22:17 GMT+01:00 Laura Abbott [off-list ref]:

quoted

On 11/06/2017 07:59 AM, Benjamin Gaignard wrote:

quoted

Instead a getting only one common device "/dev/ion" for
all the heaps this patch allow to create one device
entry ("/dev/ionX") per heap.
Getting an entry per heap could allow to set security rules
per heap and global ones for all heaps.

Allocation requests will be only allowed if the mask_id
match with device minor.
Query request could be done on any of the devices.

With this patch, sysfs looks like:

$ ls /sys/devices/
breakpoint ion platform software system virtual

From an Ion perspective, you can have

Acked-by: Laura Abbott <redacted>

Another Ack for the device model stuff would be good but I'll
assume deafening silence means nobody hates it.

Greg, can we get your point of view of this ?

It's 1 day after the merge window has closed, and my todo patch queue
looks like this:
	$ mdfrm -c ~/mail/todo/
	1523 messages in /home/gregkh/mail/todo/

Please give me a chance to catch up...

greg k-h