Re: [PATCH RFC v2 2/4] mm/mempolicy: remove redundant check in get_nodes
From: Vlastimil Babka <hidden>
Date: 2017-10-31 08:55:41
Also in:
linux-mm, lkml
On 10/27/2017 12:14 PM, Yisheng Xie wrote:
We have already checked whether maxnode is a page worth of bits, by:
maxnode > PAGE_SIZE*BITS_PER_BYTE
So no need to check it once more.
Signed-off-by: Yisheng Xie <redacted>Acked-by: Vlastimil Babka <redacted>
quoted hunk ↗ jump to hunk
--- mm/mempolicy.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 613e9d0..3b51bb3 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c@@ -1280,8 +1280,6 @@ static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask, /* When the user specified more nodes than supported just check if the non supported part is all zero. */ if (nlongs > BITS_TO_LONGS(MAX_NUMNODES)) { - if (nlongs > PAGE_SIZE/sizeof(long)) - return -EINVAL; for (k = BITS_TO_LONGS(MAX_NUMNODES); k < nlongs; k++) { unsigned long t; if (get_user(t, nmask + k))
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>