Thread (2 messages) 2 messages, 2 authors, 2017-10-22

Re: [PATCH] fs: check for DAC_READ_SEARCH instead of SYS_ADMIN

From: Theodore Ts'o <hidden>
Date: 2017-10-22 05:25:47
Also in: linux-fsdevel, lkml

On Sat, Oct 21, 2017 at 03:24:46PM +0200, Nicolas Belouin wrote:
These checks are meant to prevent leaks or attacks via directory
traversal, the use of CAP_SYS_ADMIN here is a misuse,
CAP_DAC_READ_SEARCH being way more appropriate as a process
with CAP_DAC_READ_SEARCH is entrusted with going trough all directories.
CAP_SYS_ADMIN is not meant to flag such a process.

Signed-off-by: Nicolas Belouin <redacted>
No.  lookup_dcookie() is a horrid, horrid, hack which is
*spectacularly* dangerous.  We should not be trying to encourage its
use for anything beside its single legacy user, oprofile(8), for which
CAP_SYS_ADMIN is appropriate.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help