Thread (34 messages) 34 messages, 5 authors, 2017-09-02

Re: [PATCH net-next v7 08/10] bpf: Add a Landlock sandbox example

From: Mickaël Salaün <mic@digikod.net>
Date: 2017-09-02 13:21:12
Also in: lkml, netdev

On 01/09/2017 12:25, Alban Crequy wrote:
Hi Mickaël,

On 21 August 2017 at 02:09, Mickaël Salaün [off-list ref] wrote:
quoted
Add a basic sandbox tool to create a process isolated from some part of
the system. This sandbox create a read-only environment. It is only
allowed to write to a character device such as a TTY:
...
quoted
+       /*
+        * This check allows the action on the file if it is a directory or a
+        * pipe. Otherwise, a message is printed to the eBPF log.
+        */
+       if (S_ISCHR(ret) || S_ISFIFO(ret))
+               return 0;

The comment says "directory", but the code checks for "character device".

Thanks!
Alban
Fixed, thanks!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help