Re: [PATCH 1/2] vfs: add flags parameter to ->mmap() in 'struct file_operations'
From: Christoph Hellwig <hidden>
Date: 2017-08-31 10:02:03
Also in:
dri-devel, linux-mm, nvdimm
quoted hunk ↗ jump to hunk
-static int ecryptfs_mmap(struct file *file, struct vm_area_struct *vma) +static int ecryptfs_mmap(struct file *file, struct vm_area_struct *vma, + unsigned long map_flags) { struct file *lower_file = ecryptfs_file_to_lower(file); /*@@ -179,7 +180,7 @@ static int ecryptfs_mmap(struct file *file, struct vm_area_struct *vma) */ if (!lower_file->f_op->mmap) return -ENODEV; - return generic_file_mmap(file, vma); + return generic_file_mmap(file, vma, 0);
Shouldn't ecryptfs pass on the flags? Same for coda_file_mmap and shm_mmap.
-static inline int call_mmap(struct file *file, struct vm_area_struct *vma)
+static inline int call_mmap(struct file *file, struct vm_area_struct *vma,
+ unsigned long flags)
{
- return file->f_op->mmap(file, vma);
+ return file->f_op->mmap(file, vma, flags);
}It would be great to kill this pointless wrapper while we're at it.