Re: [PATCH v2 20/22] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support
From: Moritz Fischer <moritz.fischer@ettus.com>
Date: 2017-08-17 19:12:06
Also in:
lkml
Hi, On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao [off-list ref] wrote:
quoted hunk ↗ jump to hunk
FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which need to be supported by all feature devices drivers including FME and AFU. This patch implements above 2 ioctls in Intel FPGA Accelerated Function Unit (AFU) driver. Signed-off-by: Tim Whisonant <redacted> Signed-off-by: Enno Luebbers <redacted> Signed-off-by: Shiva Rao <redacted> Signed-off-by: Christopher Rauer <redacted> Signed-off-by: Xiao Guangrong <redacted> Signed-off-by: Wu Hao <redacted> --- v2: rebased --- drivers/fpga/intel-afu-main.c | 11 +++++++++++ 1 file changed, 11 insertions(+)diff --git a/drivers/fpga/intel-afu-main.c b/drivers/fpga/intel-afu-main.c index 2a17cde..22f77f2 100644 --- a/drivers/fpga/intel-afu-main.c +++ b/drivers/fpga/intel-afu-main.c@@ -122,6 +122,13 @@ static int afu_release(struct inode *inode, struct file *filp) return 0; } +static long afu_ioctl_check_extension(struct feature_platform_data *pdata, + unsigned long arg) +{ + /* No extension support for now */
Do you maybe make that an -ENOTSUPP or -EINVAL then?
quoted hunk ↗ jump to hunk
+ return 0; +} + static long afu_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { struct platform_device *pdev = filp->private_data;@@ -132,6 +139,10 @@ static long afu_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) dev_dbg(&pdev->dev, "%s cmd 0x%x\n", __func__, cmd); switch (cmd) { + case FPGA_GET_API_VERSION: + return FPGA_API_VERSION; + case FPGA_CHECK_EXTENSION: + return afu_ioctl_check_extension(pdata, arg); default: /* * Let sub-feature's ioctl function to handle the cmd --1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks, Moritz