Re: [PATCH 04/10] fs: Introduce RWF_NOWAIT and FMODE_AIO_NOWAIT
From: Christoph Hellwig <hch@infradead.org>
Date: 2017-06-17 11:53:58
Also in:
linux-block, linux-fsdevel
On Sat, Jun 17, 2017 at 05:09:44AM +0100, Al Viro wrote:
On Thu, Jun 15, 2017 at 10:59:56AM -0500, Goldwyn Rodrigues wrote:quoted
static inline int kiocb_set_rw_flags(struct kiocb *ki, int flags) { - if (unlikely(flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC))) + if (unlikely(flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT)))Minor nit: that calls for something like if (unlikely(flags & ~RWF_ALL)quoted
return -EOPNOTSUPP;with corresponding definition.
Possibly. Note _ALL is not correct - at least RWF_HIPRI is explicitly defined a shint that can be ignored. Maybe RWF_SUPPORTED.