Re: [RFC PATCH 1/2] mm: introduce bmap_walk()

On Fri, Jun 16, 2017 at 10:22 PM, Christoph Hellwig [off-list ref] wrote:

On Fri, Jun 16, 2017 at 06:15:29PM -0700, Dan Williams wrote:

quoted

Refactor the core of generic_swapfile_activate() into bmap_walk() so
that it can be used by a new daxfile_activate() helper (to be added).

No way in hell!  generic_swapfile_activate needs to day and no new users
of ->bmap over my dead body.  It's a guaranteed to fuck up your data left,
right and center.

Certainly you're not saying that existing swapfiles are broken, so I
wonder what bugs you're talking about?

Unless you had plans to go remove bmap() I don't see how this gets in
your way at all. That said, I think "please don't add a new bmap()
user, use iomap instead" is a fair comment. You know me well enough to
know that would be all it takes to redirect my work, I can do without
the bluster.