Thread (3 messages) 3 messages, 3 authors, 2017-04-30

Re: [PATCH v2] fscrypt: Remove __packed from fscrypt_policy

flat view

From: Richard Weinberger <hidden>
Date: 2017-04-07 09:23:02
Also in: linux-fscrypt, linux-fsdevel

Am 07.04.2017 um 01:14 schrieb Joe Richey:
quoted hunk ↗ jump to hunk
From: Joe Richey <redacted>

This commit removes __packed from fscrypt_policy as it does not contain
any implicit padding and does not refer to an on-disk structure. Even
though this is a change to a UAPI file, no users will be broken as the
structure doesn't change.

Signed-off-by: Joe Richey <redacted>
---
 include/uapi/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index 048a85e9f017..f6e1c54ac5e2 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -279,7 +279,7 @@ struct fscrypt_policy {
 	__u8 filenames_encryption_mode;
 	__u8 flags;
 	__u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE];
-} __packed;
+};
Both patches are fine, just keep my Reviewed-by. :)

Thanks,
//richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help