Re: fanotify read returns with errno == EOPENSTALE

Amir Goldstein [off-list ref]:

On Thu, Apr 20, 2017 at 3:43 PM, Marko Rauhamaa
[off-list ref] wrote:

quoted

Amir Goldstein [off-list ref]:

quoted

Sorry I messed up the previous patch. please try this one:

I will try it.

Tried it. Superficially, it seems to be working, but...

quoted

More importantly, does EAGAIN here still guarantee EPOLLET semantics
of epoll(7)? IOW, if I get EAGAIN, I shouldn't have to try read(2)ing
the fanotify fd again before calling epoll_wait(2).

Yes, if you get EAGAIN it means there are no more events in the queue,
so shouldn't have to try read again.

I ran into a system hang with our real product that suggests there might
be a problem left. It would be explained if your patch generated an
EAGAIN while there were other events waiting in the queue.

I will have to investigate further.


Marko

-- 
+358 44 990 4795
Skype: marko.rauhamaa_f-secure