Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks
From: Reza Arbab <hidden>
Date: 2017-02-27 23:33:01
Also in:
linux-acpi, linux-mm, linux-s390, lkml
On Mon, Feb 27, 2017 at 10:28:17AM +0100, Michal Hocko wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h index 134a2f69c21a..a72f7f64ee26 100644 --- a/include/linux/memory_hotplug.h +++ b/include/linux/memory_hotplug.h@@ -100,8 +100,6 @@ extern void __online_page_free(struct page *page);extern int try_online_node(int nid); -extern bool memhp_auto_online; - #ifdef CONFIG_MEMORY_HOTREMOVE extern bool is_pageblock_removable_nolock(struct page *page); extern int arch_remove_memory(u64 start, u64 size);@@ -272,7 +270,7 @@ static inline void remove_memory(int nid, u64 start, u64 size) {}extern int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn, void *arg, int (*func)(struct memory_block *, void *)); -extern int add_memory(int nid, u64 start, u64 size); +extern int add_memory(int nid, u64 start, u64 size, bool online); extern int add_memory_resource(int nid, struct resource *resource, bool online); extern int zone_for_memory(int nid, u64 start, u64 size, int zone_default, bool for_device);
It would be nice if instead of a 'bool online' argument, add_memory() and add_memory_resource() took an 'int online_type', ala online_pages(). That way we could specify offline, online, online+movable, etc. -- Reza Arbab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>