Thread (56 messages) 56 messages, 6 authors, 2016-07-14
STALE3610d REVIEWED: 3 (0M)
Revisions (12)
  1. v16 [diff vs current]
  2. v17 [diff vs current]
  3. v18 [diff vs current]
  4. v19 [diff vs current]
  5. v20 [diff vs current]
  6. v22 [diff vs current]
  7. v23 current
  8. v24 [diff vs current]
  9. v25 [diff vs current]
  10. v25 [diff vs current]
  11. v27 [diff vs current]
  12. v28 [diff vs current]

[PATCH v23 04/22] vfs: Make the inode passed to inode_change_ok non-const

From: Andreas Gruenbacher <agruenba@redhat.com>
Date: 2016-06-30 13:46:55
Also in: linux-cifs, linux-ext4, linux-fsdevel, linux-nfs, linux-xfs, lkml
Subsystem: filesystems (vfs and infrastructure), the rest · Maintainers: Alexander Viro, Christian Brauner, Linus Torvalds

We will need to call iop->permission and iop->get_acl from
inode_change_ok() for additional permission checks, and both take a
non-const inode.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: J. Bruce Fields <redacted>
Reviewed-by: Andreas Dilger <redacted>
Reviewed-by: Steve French <redacted>
---
 fs/attr.c          | 2 +-
 include/linux/fs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/attr.c b/fs/attr.c
index 25b24d0..7ca7fa0 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -28,7 +28,7 @@
  * Should be called as the first thing in ->setattr implementations,
  * possibly after taking additional locks.
  */
-int inode_change_ok(const struct inode *inode, struct iattr *attr)
+int inode_change_ok(struct inode *inode, struct iattr *attr)
 {
 	unsigned int ia_valid = attr->ia_valid;
 
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 86bfa10..208f73b 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2993,7 +2993,7 @@ extern int buffer_migrate_page(struct address_space *,
 #define buffer_migrate_page NULL
 #endif
 
-extern int inode_change_ok(const struct inode *, struct iattr *);
+extern int inode_change_ok(struct inode *, struct iattr *);
 extern int inode_newsize_ok(const struct inode *, loff_t offset);
 extern void setattr_copy(struct inode *inode, const struct iattr *attr);
 
-- 
2.5.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help