[PATCH v22 04/22] vfs: Make the inode passed to inode_change_ok non-const
flat view
STALE3803d
SUPERSEDED: 3 (0M)
From: Andreas Gruenbacher <agruenba@redhat.com>
Date: 2016-05-31 11:50:36
Also in:
linux-cifs, linux-ext4, linux-fsdevel, linux-nfs, linux-xfs, lkml
Subsystem:
filesystems (vfs and infrastructure), the rest · Maintainers:
Alexander Viro, Christian Brauner, Linus Torvalds
Status: Superseded by v28 (posted 2017-02-13). [go to v28]
Revision v22 (12 revisions archived); 3 review trailers.
Revisions (12)
- v16
- v17 [diff against previous]
- v18 [diff against previous]
- v19 [diff against previous]
- v20 [diff against previous]
- v22 current [diff against previous]
- v23 [diff against previous]
- v24 [diff against previous]
- v25 [diff against previous]
- v26 [diff against previous]
- v27 [diff against previous]
- v28 [diff against previous]
We will need to call iop->permission and iop->get_acl from inode_change_ok() for additional permission checks, and both take a non-const inode. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by: J. Bruce Fields <redacted> Reviewed-by: Andreas Dilger <redacted> Reviewed-by: Steve French <redacted> --- fs/attr.c | 2 +- include/linux/fs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/attr.c b/fs/attr.c
index 25b24d0..7ca7fa0 100644
--- a/fs/attr.c
+++ b/fs/attr.c@@ -28,7 +28,7 @@ * Should be called as the first thing in ->setattr implementations, * possibly after taking additional locks. */ -int inode_change_ok(const struct inode *inode, struct iattr *attr) +int inode_change_ok(struct inode *inode, struct iattr *attr) { unsigned int ia_valid = attr->ia_valid;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 86bfa10..208f73b 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h@@ -2993,7 +2993,7 @@ extern int buffer_migrate_page(struct address_space *, #define buffer_migrate_page NULL #endif -extern int inode_change_ok(const struct inode *, struct iattr *); +extern int inode_change_ok(struct inode *, struct iattr *); extern int inode_newsize_ok(const struct inode *, loff_t offset); extern void setattr_copy(struct inode *inode, const struct iattr *attr);
--
2.5.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs