Re: [PATCH v10 4/5] tpm: Initialize TPM and get durations and timeouts
flat view
From: Jason Gunthorpe <hidden>
Date: 2016-04-15 17:18:54
Also in:
lkml
On Fri, Apr 15, 2016 at 09:50:15AM -0400, Stefan Berger wrote:
quoted hunk ↗ jump to hunk
@@ -69,12 +73,19 @@ static ssize_t vtpm_proxy_fops_read(struct file *filp, char __user *buf, size_t len; int sig, rc; - sig = wait_event_interruptible(proxy_dev->wq, proxy_dev->req_len != 0); + sig = wait_event_interruptible(proxy_dev->wq, + proxy_dev->req_len != 0 || + !(proxy_dev->state & STATE_OPENED_FLAG)); if (sig) return -EINTR;
This hunk and related doesn't look like it belongs in this patch? Suggest just merging this into the prior patch and be done with it, not really any reason to have two patches anymore. I think everything that was brought up is taken care of now.. One last read through..
static int vtpm_proxy_tpm_op_recv(struct tpm_chip *chip, u8 *buf, size_t count)
{
struct proxy_dev *proxy_dev = dev_get_drvdata(&chip->dev);
if (!proxy_dev)
return -EIO;Is that actually possible? It shouldn't be. If not please drop it an related. For both: Reviewed-by: Jason Gunthorpe <redacted> Jason