Re: [PATCH v3 06/10] sysctl: drop away useless label
From: Andy Shevchenko <hidden>
Date: 2016-04-06 11:33:23
Also in:
linux-efi, lkml
On Tue, 2016-04-05 at 15:17 -0700, Andrew Morton wrote:
On Tue, 5 Apr 2016 16:56:15 +0300 Andy Shevchenko <andriy.shevchenko@ linux.intel.com> wrote:quoted
We have no locking in bin_uuid(). Thus, we may remove the out label and use return statements directly.
Sure, but we may add locking or resource allocation in the future, in which case this change will need to be undone. I think it's better to leave the code as-is. It's presently quite typical kernel code.
I have noticed you updated the patch already. I'm fine with either. -- Andy Shevchenko [off-list ref] Intel Finland Oy