Re: [PATCH v3 7/7] crypto: AF_ALG - add support for key_id

From
David Howells <dhowells@redhat.com>
Date
2016-03-30 16:31:54
Also in
linux-crypto, lkml
Reply to
Tadeusz Struk, 2016-03-30
Tadeusz Struk [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+	keyring = request_key(&key_type_asymmetric, key_name, NULL);
+
+	err = -ENOKEY;
+	if (IS_ERR(keyring))
+		goto out;
+
+	pkey = keyring->payload.data[asym_crypto];
NAK.  This is liable to crash in future.  You may not assume that you know
what keyring->payload.data[asym_crypto] points to.

You may not use struct public_key outside of crypto/asymmetric_key/.  It's the
internal data of the software subtype.  I'll move it out of the global header
to remove the temptation;-).

You must use accessor functions such as verify_signature().  Feel free to add
further accessor functions such as query_asym_capabilities(),
create_signature(), encrypt_blob() and decrypt_blob() or something like that.

David
Thread (16 messages) 16 messages, 4 authors, last reply 2016-03-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help