On Thu, Mar 10, 2016 at 03:52:54PM -0000, ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote:

quoted

On Wed, Mar 09, 2016 at 08:52:59PM -0000, ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote:

quoted

quoted

On Wed, Mar 09, 2016 at 07:09:49PM -0000, ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote:

quoted

quoted

On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote:

quoted

This patch exposes the ioctl interface for UFS driver via SCSI

device

quoted

quoted

quoted

quoted

ioctl interface. As of now UFS driver would provide the ioctl for

query

quoted

quoted

interface to connected UFS device.

Reviewed-by: Subhash Jadavani <redacted>
Signed-off-by: Dolev Raviv <redacted>
Signed-off-by: Gilad Broner <redacted>
Signed-off-by: Yaniv Gardi <redacted>

What tool is going to use this ioctl?  Why does userspcae want to

do

quoted

quoted

quoted

something "special" with UFS devices?  Shouldn't they just be

treated

quoted

quoted

quoted

like any other normal block device?

Any userspace application can be a tool.
We already implemented and used a user space application, that sent
queries to the UFS devices in order to get information and

descriptors.

quoted

But do you want to do with that information?  Why does userspace care?

i don't really understand the subtext of your question -
as ANY ioctl cb, we decided to implement the ioctl callback of this scsi
device in order to get information like UNIT DESC, DEVICE DESC, FLAGs,
ATTRIBUTES.
When dealing with UFS devices, one should be able to read the
characteristics of the device. why ? well, why not ?

Why aren't those characteristics just exported as sysfs attributes under
control by the UFS controller driver?  Why do you need/want an ioctl for
this?

Hi greg k-h,

in our code, we used the IOCTL during runtime, in order to determine some
information about the RPMB well known lun.
with the rpmb lun ID we could then go to /dev/sgX and issue
UFS_IOCTL_QUERY to this lun and get the data -
reading the QUERY_DESC_IDN_GEOMETRY descriptor and reading the
QUERY_DESC_IDN_UNIT descriptor.

this was crucial to the work we do in RPMB.

What is RPMB?

And again, why not just use sysfs attributes on your host controller
device?  Why does this have to be a custom ioctl?

greg k-h