Hello Johannes,
On 1 March 2016 at 11:15, João Paulo Rechi Vita [off-list ref] wrote:
On 1 March 2016 at 08:43, Johannes Berg [off-list ref] wrote:
quoted
I'm fine with Jouni's change, preserving the original behaviour of
requiring TYPE_ALL or the correct type, but I'm tempted to simply
remove the type check entirely.
Thoughts?
I think this patch should keep the original logic, as this is supposed
to be a refactor only. If we decide to remove the check, we should to
it in a separate patch, to make it clear for someone looking at the
history later.
I'm fine with removing the type check (in a separate patch), but I
don't see much gain in doing so.
I just saw you picked this patch with Jouni's fix, thanks!
--
João Paulo Rechi Vita
http://about.me/jprvita