Re: aio openat Re: [PATCH 07/13] aio: enabled thread based async fsync

From
Al Viro <viro@ZenIV.linux.org.uk>
Date
2016-03-20 01:55:11
Also in
linux-fsdevel, linux-mm, lkml
Reply to
Linus Torvalds, 2016-03-20
On Sat, Mar 19, 2016 at 06:45:19PM -0700, Linus Torvalds wrote:
It actually does seem to do that, although in an admittedly rather
questionable way.

I think it should use path_openat() rather than do_filp_open(), but
passing in LOOKUP_RCU to do_filp_open() actually does work: it just
means that the retry after ECHILD/ESTALE will just do it *again* with
LOOKUP_RCU. It won't fall back to non-rcu mode, it just won't or in
the LOOKUP_RCU flag that is already set.
What would make unlazy_walk() fail?  And if it succeeds, you are not
in RCU mode anymore *without* restarting from scratch...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Thread (51 messages) 51 messages, 10 authors, last reply 2016-03-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help