Re: [PATCH v18 21/22] ext4: Add richacl support

On Mon, Mar 14, 2016 at 02:02:33PM +0100, Andreas Gruenbacher wrote:

On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig [off-list ref] wrote:

quoted

quoted

+static inline int
+ext4_acl_chmod(struct inode *inode, umode_t mode)
+{
+     if (IS_RICHACL(inode))
+             return richacl_chmod(inode, inode->i_mode);
+     return posix_acl_chmod(inode, inode->i_mode);
+}

Thi isn't ext4-specific and potentially duplicated in every caller.
Please provide this as a common helper.

This can go in neither fs.h nor posix_acl.h nor richacl.h unless we
turn it into a macro, and I don't think we want to add a new header
file for such extreme trivia.

I'd expect us to grow a few more of thos helper if we get the sharing
right (either a real common base object, or wrappers for anything
dealing with the acl pointers in the inode), so a new linux/acl.h
should be fine.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs