Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation

On (02/19/16 10:39), Joonsoo Kim wrote:
[..]

quoted

not sure if it's worth mentioning in the comment, but the other
concern here is the performance impact of an extra function call,
I believe. otherwise, Joonsoo would just do:

It's very natural thing so I'm not sure it is worth mentioning.

agree.

quoted

and in mm/debug_page_ref.c

void __page_ref_set(struct page *page, int v)
{
        if (trace_page_ref_set_enabled())
                trace_page_ref_set(page, v);
}
EXPORT_SYMBOL(__page_ref_set);
EXPORT_TRACEPOINT_SYMBOL(page_ref_set);

It is what I did in v1.

ah... indeed. well, "That was a year ago, how am I suppose to remember"

	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>