Re: [PATCH v4 04/22] kthread: Add create_kthread_worker*()
From: Tejun Heo <hidden>
Date: 2016-02-16 16:08:07
Also in:
linux-mm, lkml
From: Tejun Heo <hidden>
Date: 2016-02-16 16:08:07
Also in:
linux-mm, lkml
Hello, On Tue, Feb 16, 2016 at 04:44:43PM +0100, Petr Mladek wrote:
I wanted to be sure. The cpu number is later passed to cpu_to_node(cpu) in kthread_create_on_cpu(). I am going to replace this with a check against nr_cpu_ids in kthread_create_on_cpu() which makes more sense. I might be too paranoid. But this is slow path. People do mistakes...
idk, that just ended up adding a subtly broken code which checks for an unlikely condition which would cause a crash anyway. I don't see the point. If you want to insist on it, please at least make it a WARN_ON(). It's a clear kernel bug. Thanks. -- tejun