Re: [RFC PATCH v4 2/6] module: preserve Elf information for livepatch modules
From: Petr Mladek <pmladek@suse.com>
Date: 2016-02-10 15:53:19
Also in:
linux-s390, lkml
On Wed 2016-02-03 20:11:07, Jessica Yu wrote:
quoted hunk ↗ jump to hunk
diff --git a/kernel/module.c b/kernel/module.c index 71c77ed..9c16eb2 100644 --- a/kernel/module.c +++ b/kernel/module.c@@ -2676,6 +2764,23 @@ static int copy_module_from_user(const void __user *umod, unsigned long len, return 0; } +#ifdef CONFIG_LIVEPATCH +static int find_livepatch_modinfo(struct module *mod, struct load_info *info) +{ + mod->klp = get_modinfo(info, "livepatch") ? true : false; + + return 0; +} +#else /* !CONFIG_LIVEPATCH */ +static int find_livepatch_modinfo(struct module *mod, struct load_info *info) +{ + if (get_modinfo(info, "livepatch"))
One more thing. I suggest to write a friendly message here. For example:
pr_err("LifePatch support is not available. Rejecting the module: s\n",
mod->name);
It might safe some debugging a poor user or developer.
+ return -ENOEXEC; + + return 0; +} +#endif /* CONFIG_LIVEPATCH */ +
Best Regards, Petr