Re: [PATCH 2/5] iio: hmc5843: Swap suspend and resume implementations
From: Jonathan Cameron <hidden>
Date: 2016-02-09 22:14:22
Also in:
linux-iio, lkml
On 07/02/16 22:21, Cristina Moraru wrote:
Swap implementations of hmc5843_common_suspend and hmc5843_common_resume functions for they have been inversed. Device should go on SLEEP mode on suspend and on CONTINUOUS mode on resume. Signed-off-by: Cristina Moraru <redacted>
I'd normally apply this as a fix, but to keep things simple with the move out of staging I've just applied it to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. It's been there a long time an no one has noticed, so I'm guessing any hardware platforms with this on aren't going in for power management! Jonathan
quoted hunk ↗ jump to hunk
--- drivers/staging/iio/magnetometer/hmc5843_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c index 4e2a7ec..dca8d64 100644 --- a/drivers/staging/iio/magnetometer/hmc5843_core.c +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c@@ -612,14 +612,14 @@ static const unsigned long hmc5843_scan_masks[] = {0x7, 0}; int hmc5843_common_suspend(struct device *dev) { return hmc5843_set_mode(iio_priv(dev_get_drvdata(dev)), - HMC5843_MODE_CONVERSION_CONTINUOUS); + HMC5843_MODE_SLEEP); } EXPORT_SYMBOL(hmc5843_common_suspend); int hmc5843_common_resume(struct device *dev) { return hmc5843_set_mode(iio_priv(dev_get_drvdata(dev)), - HMC5843_MODE_SLEEP); + HMC5843_MODE_CONVERSION_CONTINUOUS); } EXPORT_SYMBOL(hmc5843_common_resume);