Re: [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT
From: Madars Vitolins <hidden>
Date: 2016-02-05 09:50:28
Also in:
linux-fsdevel, lkml
Andrew Morton @ 2016-02-05 00:59 rakstīja:
On Thu, 04 Feb 2016 23:44:05 +0200 Madars Vitolins [off-list ref] wrote:quoted
Hi Jason, Just run off the original tests with this patch (eventpoll.c from 4.5-rc2 + patch bellow). Got the same good results, no regression. $ time ./bankcl Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 1359856158.04 USD Account balance is: 101528948.40 USD real 0m41.826s user 0m29.513s sys 0m6.490s Test case: https://mvitolin.wordpress.com/2015/12/05/endurox-testing-epollexclusive-flag/ PS, Original cases 0m24.953s vs 0m41.826s now probably is related with my pc setup. As I just now re-run test with original patch, got the same ~41 sec. So I am fine with this patch!Thanks, I shall add your Tested-by: One thing we're sorely missing is an epoll test suite, in tools/testing/selftests. If anyone has anything which we can use to kick things off, please hand it over ;)
Not bad idea, probably we need a "tools/testing/selftests/eventpoll" folder under which we should have test cases for various epoll scenarios with common "run.sh". In spare time I can try to build a case for EXCLUSIVE flag (with queues & multiple processes :) ). Thanks, Madars