Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

From
One Thousand Gnomes <hidden>
Date
2016-01-06 22:33:10
Also in
linux-mips, linux-serial, lkml
Reply to
unknown sender, 2016-01-06
On Wed, 6 Jan 2016 22:00:43 +0000
[off-list ref] wrote:
On 01/05/2016 03:50 PM, One Thousand Gnomes wrote:
quoted
quoted
+#define PIC32_SDEV_NAME		"ttyS"
+#define PIC32_SDEV_MAJOR	TTY_MAJOR
+#define PIC32_SDEV_MINOR	64
No. Same goes for you as every one of the forty other people a year who
try and claim their console is ttyS. If it's not an 8250 it isn't.

ttyS is the 8250, use dynamic major and minor and a different name.
Ok. Is there a naming convention documented anywhere? How about ttyPIC?
We used to document it but the document was always stale. ttyPIC sounds
fine providing nobody else is using it (and I don't think they are but
grep is your friend). We enforce the rule because in the early days lots
of people re-used ttyS for their chip. Then their chip grew an external
bus or turned into a SoC and a 16x50 got added and it all broke.

ttyPIC ought to be fine because even if you get new PIC devices with a
different uart you aren't likely to have both of the PIC cores on the
same device.

Alan
Thread (7 messages) 7 messages, 4 authors, last reply 2016-01-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help