Re: [PATCH v8 39/55] [media] media controller: get rid of entity subtype on Kernel
From: Laurent Pinchart <hidden>
Date: 2015-12-06 01:03:13
Also in:
linux-media
Possibly related (same subject, not in this thread)
- 2015-08-31 · Re: [PATCH v8 39/55] [media] media controller: get rid of entity subtype on Kernel · Hans Verkuil <hidden>
- 2015-08-30 · [PATCH v8 39/55] [media] media controller: get rid of entity subtype on Kernel · Mauro Carvalho Chehab <hidden>
Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:02:59 Mauro Carvalho Chehab wrote:
Don't use anymore the type/subtype entity data/macros inside the Kernel. Signed-off-by: Mauro Carvalho Chehab <redacted>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
quoted hunk ↗ jump to hunk
diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 220864319d21..7320cdc45833 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h@@ -185,16 +185,6 @@ struct media_intf_devnode { u32 minor; }; -static inline u32 media_entity_type(struct media_entity *entity) -{ - return entity->type & MEDIA_ENT_TYPE_MASK; -} - -static inline u32 media_entity_subtype(struct media_entity *entity) -{ - return entity->type & MEDIA_ENT_SUBTYPE_MASK; -} - static inline u32 media_entity_id(struct media_entity *entity) { return entity->graph_obj.id;diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 3d6210095336..f90147cb9b57 100644 --- a/include/uapi/linux/media.h +++ b/include/uapi/linux/media.h@@ -42,8 +42,6 @@ struct media_device_info { #define MEDIA_ENT_ID_FLAG_NEXT (1 << 31) -/* Used values for media_entity_desc::type */ - /* * Initial value to be used when a new entity is created * Drivers should change it to something useful
-- Regards, Laurent Pinchart