Thread (32 messages) flat view 32 messages, 6 authors, 2016-01-02

Re: [PATCH 3/8] cgroup: introduce cgroup namespaces

From: Tejun Heo <hidden>
Date: 2015-12-23 16:15:33
Also in: cgroups, lkml

Hello,

On Tue, Dec 22, 2015 at 10:23:24PM -0600, serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org wrote:
...
+char *cgroup_path(struct cgroup *cgrp, char *buf, size_t buflen)
+{
+	int ret;
+	
+	ret = cgroup_path_ns(cgrp, buf, buflen, current->nsproxy->cgroup_ns);
+	if (ret < 0 || ret >= buflen)
+		return NULL;
+	return buf;
+}
+EXPORT_SYMBOL_GPL(cgroup_path);
Shouldn't this function check whether it's being called from a task
context?  e.g. it could be being called from an irq handler and may
end up scoping the path incorrectly.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help