Re: [RFC PATCH v2 2/6] module: preserve Elf information for livepatch modules
From: Miroslav Benes <mbenes@suse.cz>
Date: 2015-12-16 10:58:59
Also in:
linux-s390, lkml
On Mon, 30 Nov 2015, Jessica Yu wrote:
quoted hunk ↗ jump to hunk
@@ -3530,6 +3614,16 @@ static int load_module(struct load_info *info, const char __user *uargs, if (err < 0) goto bug_cleanup; + /* + * Save sechdrs, indices, and other data from info + * in order to patch to-be-loaded modules. + * Do not call free_copy() for livepatch modules. + */ + if (mod->klp) + err = copy_module_elf(mod, info); + if (err < 0) + goto bug_cleanup; +
I think goto bug_cleanup is not sufficient. Just before this hunk sysfs is created. So in case of error here we should call mod_sysfs_teardown() or something before going to bug_cleanup. That is new error label is needed before bug_cleanup. Correct? Miroslav