Re: [PATCH] net: add Qualcomm IPC router

From: Bjorn Andersson <redacted>
Date: Fri, 11 Dec 2015 12:41:59 -0800

+static unsigned int qrtr_local_nid = 1;
+module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
+MODULE_PARM_DESC(idVendor, "Local Node Identifier");

Module parameters suck.

Allow the user to choose this dynamically.  You have roughtly two choices.

1) Subvert the 'protocol' field passed to ->create() and use that, it is
   being ignored otherwise.

2) Put it into the socket address for bind().