Re: [PATCH 14/18] [media] media-device: export the entity function via new ioctl
From: Laurent Pinchart <hidden>
Date: 2015-11-23 17:46:14
Also in:
linux-media
Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:57 Mauro Carvalho Chehab wrote:
quoted hunk ↗ jump to hunk
Now that entities have a main function, expose it via MEDIA_IOC_G_TOPOLOGY ioctl. Signed-off-by: Mauro Carvalho Chehab <redacted>diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index ccef9621d147..32090030c342 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c@@ -263,6 +263,7 @@ static long __media_device_get_topology(structmedia_device *mdev, /* Copy fields to userspace struct if not error */ memset(&uentity, 0, sizeof(uentity)); uentity.id = entity->graph_obj.id; + uentity.function = entity->function; strncpy(uentity.name, entity->name, sizeof(uentity.name));diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 69433405aec2..d232cc680c67 100644 --- a/include/uapi/linux/media.h +++ b/include/uapi/linux/media.h@@ -284,7 +284,8 @@ struct media_links_enum { struct media_v2_entity { __u32 id; char name[64]; /* FIXME: move to a property? (RFC says so) */ - __u16 reserved[14]; + __u32 function; /* Main function of the entity */
Shouldn't we use kerneldoc instead of inline comments ? Also, as this is the main function only, I'd mention that in the subject line. The implementation itself looks fine to me, I'll discuss the API over the documentation patch.
+ __u16 reserved[12]; }; /* Should match the specific fields at media_intf_devnode */
-- Regards, Laurent Pinchart