Thread (1 message) 1 message, 1 author, 2015-11-14

[PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others

DORMANTno replies

From: Bamvor Jian Zhang <hidden>
Date: 2015-11-14 06:01:52
Subsystem: kernel selftest framework, the rest · Maintainers: Shuah Khan, Shuah Khan, Linus Torvalds

Possibly related (same subject, not in this thread)

User need to provide cap-ng.h and libcap-ng.so for cross compiling
which could be done by pass extra cflags to EXTRA_CLAGS. But other
testcases pass CFLAGS instead.

Change CLAGS ':=' to CLAGS '+=' to align with others. Delete useless
EXTRA_CLAGS at the same time.

Signed-off-by: Bamvor Jian Zhang <redacted>
---
 tools/testing/selftests/capabilities/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile
index 8c8f0c1..47337fb 100644
--- a/tools/testing/selftests/capabilities/Makefile
+++ b/tools/testing/selftests/capabilities/Makefile
@@ -7,7 +7,7 @@ include ../lib.mk
 TARGETS := validate_cap test_execve
 TEST_PROGS := test_execve
 
-CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
+CFLAGS += -O2 -g -std=gnu99 -Wall -lcap-ng
 
 all: $(TARGETS)
 
@@ -15,4 +15,4 @@ clean:
 	$(RM) $(TARGETS)
 
 $(TARGETS): %: %.c
-	$(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
+	$(CC) -o $@ $(CFLAGS) $^ -lrt -ldl
-- 
2.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help