Thread (8 messages) 8 messages, 3 authors, 2015-11-13

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

From: Seymour, Shane M <hidden>
Date: 2015-11-13 03:36:21
Also in: linux-fsdevel, lkml

I don't have a device large enough to test for signedness errors, since passing 
huge values for start and len never make it past the i_size_read check.
If you have someone trying to bypass your sanity checks then if start=18446744073709551104 and len=1024 the result of adding them together will be 512 (subtracting an extra 1 in the patched code to get 511 for end). That will pass the i_size_read check won't it? If so that would cause lstart in truncate_inode_pages_range() to be -512. I don't know what truncate_inode_pages_range() will do with a negative lstart value like that but it seems like an unusual value for your code to be willing to pass into truncate_inode_pages_range().

Shane
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help